This edition of the Core Weekly report highlights changes in PrestaShop’s core codebase from Monday 6th to Sunday 12th of January 2020.
General messages
Dear developers,
If you have not read it yet, please check our statement about a critical security vulnerability in PrestaShop Modules.
Also activity on prestashop is resuming back to normal now with both contributions and reviews coming back stronger. The team is mainly focused on finishing the remaining 1.7.6.x issues in order to be able to release 1.7.6.3 soon.
A quick update about PrestaShop’s GitHub issues and pull requests:
- 58 new issues have been created in the project repositories;
- 47 issues have been closed, including 18 fixed issues on the core;
- 67 pull requests have been opened in the project repositories;
- 92 pull requests have been closed, including 85 merged pull requests.
Code changes in the ‘develop’ branch
Core
- #17067: Fix phpdoc on Category constructor. Thank you @zalexki
- #17048: Update nginx configuration, by @PierreRambaud
- #16714: Update composer.json requirements. Thank you @gavinkalika
- #8770: CO: remove file ‘fileType’ when deleting images. Thank you @marekhanus
Back office
- #17079: Improve modal object without using this. Thank you @NeOMakinG
- #16883: Fixed filtering for date in Back Office / Logs. Thank you @PrestaworksNiklas
- #16860: Fix United Kingdom VAT issue for all EU countries. Thank you @jf-viguier
- #16820: Enable confirm modal for catalog > files listing for bulk delete action, by @matks
- #16765: Fix recursive check of updated files. Thank you @Darhazer
- #16668: Integrate a Vue component to manage Currency customization in the BO, by @jolelievre
- #16207: Migrate summary block of BO create order page. Thank you @zuk3975
- #16150: Migrate order product management. Thank you @sarjon
- #15300: Migration for Sell > Customers > Addresses create/edit forms. Thank you @RaimondasSapola
Front office
- #17005: Adding default “Select” when sort not up in FO is selected on category page. Thank you @NeOMakinG
- #16724: Fix multiple cart rules calculation. Thank you @atomiix
- #16574: Fix product cannot be deleted from cart IF another customization is made and not added to cart yet. Thank you @Hlavtox
- #16520: Fixing contact layout not working at all. Thank you @NeOMakinG
- #15284: Color and texture consistent when both are set. Thank you @davidglezz
- #15277: Combine two equal adjacent selectors. Thank you @davidglezz
Tests
- #17094: Add twig lint check and move bash script from tests-legacy to tests, by @matks
- #17092: Functional tests - Fix other options test. Thank you @nesrineabdmouleh
- #17091: Functional tests - Fix Crud language test, by @boubkerbribri
- #17084: Functional tests - Fix error in the test Enable/Disable invoices. Thank you @nesrineabdmouleh
- #17076: Tests - Fix dockerfile for puppeteer, by @boubkerbribri
- #17066: Functional tests - Update confirm delete files method, by @boubkerbribri
- #17061: Functional tests - Add base page for localization, by @boubkerbribri
- #17060: Functional tests - Filter addresses table. Thank you @nesrineabdmouleh
- #17052: Functional tests - Add new test ‘Crud language test’, by @boubkerbribri
- #17047: Functional tests - Enable disable image in delivery slip file. Thank you @nesrineabdmouleh
- #17041: Functional tests - Fix tests brands and skip test Create unofficial currencies, by @boubkerbribri
- #17029: Functional Tests - Enable/Disable shop. Thank you @nesrineabdmouleh
- #17027: Functional tests - add test ‘Filter modules by status’, by @boubkerbribri
- #17013: Functional tests - Separate tests team employees and profiles, by @boubkerbribri
- #17009: Functional tests - add test ‘Preview Email Themes’, by @boubkerbribri
- #16998: Fix #16997 - assertion of first/classic theme from unsorted list. Thank you @mvorisek
- #16967: Functional Tests - Add number verification for delivery slip file. Thank you @nesrineabdmouleh
- #16963: Functional tests - add test ‘filter languages’, by @boubkerbribri
- #16809: Fix date parsing in tests when TZ is changed to non-UTC during tests. Thank you @mvorisek
- #16632: Replace deprecated “create_function”. Thank you @mvorisek
Code changes in the ‘1.7.6.x’ branch (for 1.7.6.3)
Core
- #17050: Quick access error when having a wrong url, by @PierreRambaud
Back office
- #17087: Define alert message when error are found in Category Form, by @Progi1984
- #17071: Fix recursive check of updated files - backport of #16765, by @matks
- #17065: Fix encoding on product name in viewed product, by @Progi1984
- #17036: Protect modules vendor folder on install/upgrade/enable, by @jolelievre
- #16742: Can’t export data more than filters limits, by @PierreRambaud
- #16696: Fix email theme permission. Thank you @atomiix
Front office
- #17030: Ignore rtl assets and remove _rtl.css files. Thank you @NeOMakinG
- #16852: Fix a bug where changing quantity on product quickview adds products tags on ever products. Thank you @NeOMakinG
Web services
Code changes in modules, themes & tools
QA nightly results
- #16: Add support for pending colors, by @SimonGrn
- #15: add possibility to check pending tests, by @SimonGrn
Changes in developer documentation
- #439: Add validation rule about altering other modules, by @Quetzacoalt91
- #438: Update links to README for Puppeteer tests, by @SimonGrn
- #436: Add mbstring as required, by @eternoendless
- #435: Update alert block for composer dependencies, by @Quetzacoalt91
- #434: Add benchmark informations from white paper, by @tomlev
- #433: Create dedicated page for validation checklist, by @Quetzacoalt91
- #408: Update _index.md. Thank you @guirou62
- #381: Add documentation for updatedProduct. Thank you @saturnxxi
- #293: Update installation instructions. Thank you @LocalHeroPro
Gamification module
Faceted search module
Auto Upgrade module
- #346: Fix codestyle and merge master into dev, by @matks
- #344: Update license headers & add all index.php, by @Quetzacoalt91
Share buttons module
- #29: Remove Google+. Thank you @micka-fdz
Product Comments module
- #47: Correct position on modal comment mobile. Thank you @NeOMakinG
Prestashop UI Kit
- #83: Add help-box and improve popover component. Thank you @NeOMakinG
- #82: Improve Breadcrumbs. Thank you @NeOMakinG
- #80: Modal improvements (box shadow, border-radius, paddings..). Thank you @NeOMakinG
- #78: Change border color and adding margin to checkbox material element. Thank you @NeOMakinG
- #75: Add toast modifier to alert component. Thank you @NeOMakinG
- #70: Adjust colors, sizes of buttons group and buttons group dropdown. Thank you @NeOMakinG
- #69: Adjust colors, sizes or primary buttons and icons. Thank you @NeOMakinG
- #68: Bump mixin-deep from 1.3.1 to 1.3.2. Thank you @dependabot[bot]
Main menu module
- #28: Fix updating custom links + fix for relative links. Thank you @sharkooon
Email Alerts module
Email subscription module
- #47: Fix issue where html tags from ps_emailsubscription module would be escaped and not interpreted as HTML. Thank you @NeOMakinG
GSitemap module
- #127: Fix failure when generating sitemap with >25000 links. Thank you @DavidBoone
Search bar module
New products module
Dash Activity module
- #16: Remove addjquery, by @matthieu-rolland
- #15: Fix online visitor values. Thank you @ckubitza
Socialfollow module
- #13: No more Google+. Thank you @kpodemski
Thank you to the contributors whose pull requests were merged since the last Core Weekly Report: @matks, @nesrineabdmouleh, @boubkerbribri, @Progi1984, @SimonGrn, @NeOMakinG, @Quetzacoalt91, @atomiix, @zalexki, @PierreRambaud, @eternoendless, @jolelievre, @micka-fdz, @tomlev, @mvorisek, @PrestaworksNiklas, @jf-viguier, @Darhazer, @gavinkalika, @sharkooon, @Hlavtox, @guirou62, @DavidBoone, @dependabot[bot], @zuk3975, @sarjon, @saturnxxi, @Oksydan, @matthieu-rolland, @RaimondasSapola, @davidglezz, @ckubitza, @LocalHeroPro, @kpodemski, @marekhanus!
Thank you to the contributors whose PRs haven’t been merged yet! And of course, a big thank you to all those who contribute with issues and comments on GitHub!
If you want to contribute to PrestaShop with code, please read these pages first:
…and if you do not know how to fix an issue but wish to report it, please read this: How to use GitHub to report an issue. Thank you!
Happy contributin’ everyone!