This edition of the Core Weekly report highlights changes in PrestaShop’s core codebase from Monday 27th of January to Sunday 2nd of February 2020.
General messages
Dear developers,
This week we introduced a new tool in our CI pipeline that we believe will make PrestaShop Javascript a lot easier to read and maintain: we now use ESLint on the modern BO theme files. This popular tool will help us ensure the monitored code is written in a consistent way, following our code conventions. It also looks for possible bugs and issues in the code and reports them at build time.
A quick update about PrestaShop’s GitHub issues and pull requests:
- 56 new issues have been created in the project repositories;
- 65 issues have been closed, including 11 fixed issues on the core;
- 70 pull requests have been opened in the project repositories;
- 67 pull requests have been closed, including 50 merged pull requests.
Code changes in the ‘develop’ branch
Core
- #17446: Fix PHP CS FIXER - again, by @matks
- #17434: Update eslint config to check for hidden directories and files, by @PierreRambaud
- #17419: Enable closure to be appended into LazyArray, by @matks
- #17389: Do not force the npm to be updated in the build.sh file, by @PierreRambaud
- #17369: Update PULL_REQUEST_TEMPLATE.md, by @PierreRambaud
Back office
- #17391: Fix develop according to linter, by @matks
- #17135: Orders > Product : Display “Stock Location” column only if it is not empty, by @Progi1984
- #16704: Implement eslint on new-theme directory, by @PierreRambaud
Front office
- #17402: Fix reversed product sorting. Thank you @micka-fdz
- #17294: Refresh cart summary when adding a voucher. Thank you @idnovate
- #17203: Add override hooks into Presenters, by @matks
Installer
- #17340: Remove share buttons after install, by @eternoendless
Web services
- #17233: Fixed error when generating link_rewrite with API. Thank you @Hherreros
- #16553: Avoids webservice to create duplicated customers with same email. Thank you @BlackKerio
- #16431: Webservice: Updating category position is changed. Thank you @gerdus
Merge
- #17466: Merge 1.7.7.x into develop - 31/01/2020, by @matks
- #17387: Merge 1.7.7.x into develop - 28/01/2020, by @matks
Code changes in the ‘1.7.7.x’ (for v1.7.7.0)
Core
- #17307: Do not force memory_limit in index_cli.php, by @PierreRambaud
- #17288: Upgrade Symfony 3.4. Thank you @mvorisek
Back office
- #17413: Fixed warning about Maxmind DB in Geolocalization page, by @Progi1984
- #17404: Fix order creation bug due to wrong computing precision, by @matthieu-rolland
- #17381: Show product customizations in the order BO page, by @atomiix
- #17377: Fix modal not being hidden sometimes, by @atomiix
- #17373: Fix currency localization, by @atomiix
- #17331: ProfileId accepts int and string as input type although int value is required, by @jolelievre
- #17325: Fix cart re-rendering after customer not found in Order creation. Thank you @zuk3975
- #17287: Enable bulk delete modal for Languages, Taxes, CMS Pages, CMS Cats, by @matks
- #17279: Fix monitoring page sorting, by @matks
- #17211: Reintegrate partial refund in the order view page, by @jolelievre
- #17191: Translate exception message when customer not found on address creation form. Thank you @sowbiba
- #17187: Delete migrated AdminRequestSqlController again - part 2, by @matks
- #17077: Remove unused legacy Customer Adresses files, by @matks
- #16722: “Orders > Products” : Display content of a pack, by @Progi1984
Front office
- #17410: Add FO hook displayFooterCategory, by @matks
- #17349: Classic Theme : enable some hooks for BlockReassurance, by @Progi1984
- #17342: Make rewrite pattern non greedy. Thank you @andromaque
- #16863: Fix a bug where product images were not scrollable after product refresh, by @NeOMakinG
Tests
- #17443: Functional tests - Add delete modal for tests (taxes and cms pages), by @boubkerbribri
- #17418: Functional tests - adding additional information to tests, by @boubkerbribri
- #17405: Functional tests - Improve test enableDisableAccentedURL, by @boubkerbribri
- #17386: Functional tests - Enable unofficial currency, by @boubkerbribri
- #17375: Functional tests - Enable disable accented url. Thank you @nesrineabdmouleh
- #17372: Functional tests - Activate tests Profiles, by @boubkerbribri
- #17213: Functional tests - Enable disable catalog mode from product settings page. Thank you @nesrineabdmouleh
Code changes in modules, themes & tools
TranslationTools Bundle
QA nightly results
Changes in developer documentation
- #452: Add details about assets compiling in the localhost page, by @jolelievre
Live Demo Devices
- #12: Allow UI to be hidden with a no_ui param, by @Quetzacoalt91
Open Source
- #29: Added open source format, open source fonts, vector arrows. Thank you @notklaatu
Social Follow module
- #15: Add linkedin. Thank you @davideapvd
Thank you to the contributors whose pull requests were merged since the last Core Weekly Report: @matks, @boubkerbribri, @PierreRambaud, @Progi1984, @matthieu-rolland, @SimonGrn, @micka-fdz, @jolelievre, @Quetzacoalt91, @atomiix, @nesrineabdmouleh, @andromaque, @eternoendless, @zuk3975, @notklaatu, @idnovate, @mvorisek, @Hherreros, @sowbiba, @davideapvd, @NeOMakinG, @BlackKerio, @gerdus!
Thank you to the contributors whose PRs haven’t been merged yet! And of course, a big thank you to all those who contribute with issues and comments on GitHub!
If you want to contribute to PrestaShop with code, please read these pages first:
…and if you do not know how to fix an issue but wish to report it, please read this: How to use GitHub to report an issue. Thank you!
Happy contributin’ everyone!