This edition of the Core Weekly report highlights changes in PrestaShop’s core codebase from Monday 20th to Sunday 26th of July 2020.
General messages
Last week we announced the opening of our Bug Bounty program. This was a very important milestone for us and we are confident that it will bring PrestaShop project to a new level of security in 2020.
In the meantime, the v4 of our Google Analytics module is on its way and the Wishlist block module is in good progress too.
Finally a lot of efforts are still being directed on fixing the last known bugs in PrestaShop 1.7.7 in order to deliver soon a first Release Candidate. But these last bugs are complex and require a huge collaboration of software and QA teams to be fully fixed.
Releases
A quick update about PrestaShop’s GitHub issues and pull requests:
- 77 new issues have been created in the project repositories;
- 60 issues have been closed, including 14 fixed issues on the core;
- 190 pull requests have been opened in the project repositories;
- 185 pull requests have been closed, including 163 merged pull requests.
Code changes in the ‘develop’ branch
Core
- #20235: Remove useless ini_set for Windows, by @PierreRambaud
Back office
- #20289: Fix wrongly placed block end tag in carts/helpers/view/view.tpl. Thank you @Sinepel
- #20260: Fix color of cursor using arrow keyboard on product page, by @NeOMakinG
- #20253: Grid row delete confirmation modal - Customers > Addresses, by @sowbiba
- #20242: Add deprecated message on js files in order to inform about next major possible deletions, by @NeOMakinG
- #20224: BO PRODUCT SPECIFIC PRICE TAB Add id_specific_price in list. Thank you @PululuK
- #20204: Simplified credit slip options. Thank you @JevgenijVisockij
- #20195: Log when webservice key is deleted. Thank you @ksaandev
- #20016: Simplify Address form. Thank you @JevgenijVisockij
- #19838: Add modal actions to attribute and attribute actions. Thank you @JevgenijVisockij
Front office
- #20297: Simplify is_gift checking in checkout tpl. Thank you @davidglezz
- #20143: Add actionGetProductPropertiesAfterUnitPrice hook. Thank you @olecorre
- #20139: Module widget display fix. Thank you @Oksydan
- #20002: Add selectors mapping so themes can override it, by @NeOMakinG
- #19830: Allow override of checkout process. Thank you @ksaandev
Tests
- #20273: Functional tests - Fix confirm delete modal selector for addresses page, by @boubkerbribri
- #20262: Functional tests - Fix click on delete confirmation modal - Customers > Addresses. Thank you @nesrineabdmouleh
- #20258: Add const MAIL_DIR for phpstan bootstrap, by @matks
Code changes in the ‘1.7.7.x’ branch
Back office
- #20263: Fix bad redirection after error in address controller, by @matks
- #20111: Fix order max quantity, by @jolelievre
- #20083: Refactoring of the Order Updater and multiple related bugfixes, by @jolelievre
Tests
- #20312: Improve combination tests, use IDs instead of names to check quantities, by @jolelievre
- #20293: Functional tests - Add new test ‘Carrier restrictions’, by @boubkerbribri
- #20280: Functional tests - Create new test ‘View customer from orders page’, by @boubkerbribri
- #20241: Functional tests - Modify translation. Thank you @nesrineabdmouleh
Code changes in modules, themes & tools
Wishlist block module
- #70: Add quantity while adding to cart, by @NeOMakinG
- #68: Fix some trads domain and false sort error, add last added sort for wishlist products. Thank you @zalexki
- #67: Change translation to respect native module workflow, by @NeOMakinG
- #66: Some feedbacks from our PM, by @NeOMakinG
- #65: Fix unknown service on ps 1.7.6, by @Quetzacoalt91
- #64: Delete unused filter button, by @NeOMakinG
- #63: Hover responsive, by @NeOMakinG
- #62: Avoid javascript errors in BO, by @NeOMakinG
- #61: Fix builds, by @Quetzacoalt91
- #60: Assert write permission are given before altering lists, by @Quetzacoalt91
Changes in developer documentation
- #644: fix missing quote. Thank you @zalexki
- #642: Change jquery to v3 instead of v2, by @NeOMakinG
- #641: Fix CI/CD title abbreviation to entire words, by @eternoendless
- #637: Add some useful resources to deal with PRs, by @ttoine
- #636: Update parent-child-feature.md. Thank you @joserprieto
- #635: Add project section & move release section inside it, by @eternoendless
- #632: Update links and content for ModuleFrontControllers, by @Quetzacoalt91
Google Analytics module
- #56: Fix reported error in CI, by @Quetzacoalt91
- #50: Major refacto : 4.0.0, by @apacios
Quality Assurance tools module
Check Payment module
Product Comments module
- #59: Fix typo in query. Thank you @kpodemski
- #58: Force installation in all stores context. Thank you @kpodemski
- #55: Disable row clicking action in moderate and comment list. Thank you @PululuK
- #45: Customer anonymisation. Thank you @Oksydan
Shopping cart module
Order Notifications on Favicon module
- #20: Bump prestashop/php-dev-tools from 3.4 to 3.8. Thank you @dependabot[bot]
Customer reassurance block module
Featured products module
- #29: Release 2.1.0, by @Progi1984
- #28: Display categories using “categories” type in admin form. Thank you @rmilecki
Faceted search module
- #185: Bump eslint from 5.15.0 to 5.16.0. Thank you @dependabot-preview[bot]
- #183: Bump babel-loader from 8.0.5 to 8.1.0. Thank you @dependabot-preview[bot]
- #182: Bump mini-css-extract-plugin from 0.5.0 to 0.9.0. Thank you @dependabot-preview[bot]
- #181: Bump style-loader from 0.23.1 to 1.2.1. Thank you @dependabot-preview[bot]
- #180: Bump friendsofphp/php-cs-fixer from 2.16.3 to 2.16.4. Thank you @dependabot-preview[bot]
- #179: Bump mockery/mockery from 1.3.1 to 1.3.2. Thank you @dependabot-preview[bot]
- #177: Remove useless part of code, by @PierreRambaud
- #172: Added sort by bestsellers. Thank you @dgonzalez360
- #170: Ajax update product list on select lists. Thank you @Leenwt
Stylelint Configuration
- #2: Bump lodash from 4.17.15 to 4.17.19. Thank you @dependabot[bot]
Core Weekly Generator tool
- #41: Bump lodash from 4.17.15 to 4.17.19. Thank you @dependabot[bot]
Example mailtheme module
- #8: Bump lodash from 4.17.15 to 4.17.19. Thank you @dependabot[bot]
Email Alerts module
- #58: Wrong condition result broke module installation. Thank you @kpodemski
Changes performed by scripts for license headers and dependabot configuration
- #10: Fix license headers - part 2, by @matks
- #9: Add dependabot config file, by @PierreRambaud
- #14: Fix license headers - part 2, by @matks
- #13: Add dependabot config file, by @PierreRambaud
- #15: Fix license headers - part 2, by @matks
- #14: Add dependabot config file, by @PierreRambaud
- #10: Fix license headers - part 2, by @matks
- #9: Add dependabot config file, by @PierreRambaud
- #17: Fix license headers - part 2, by @matks
- #16: Add dependabot config file, by @PierreRambaud
- #11: Fix license headers - part 2, by @matks
- #10: Add dependabot config file, by @PierreRambaud
- #8: Fix license headers - part 2, by @matks
- #7: Add dependabot config file, by @PierreRambaud
- #9: Fix license headers - part 2, by @matks
- #8: Add dependabot config file, by @PierreRambaud
- #15: Fix license headers - part 2, by @matks
- #14: Add dependabot config file, by @PierreRambaud
- #17: Fix license headers - part 2, by @matks
- #16: Add dependabot config file, by @PierreRambaud
- #12: Fix license headers - part 2, by @matks
- #11: Add dependabot config file, by @PierreRambaud
- #16: Fix license headers - part 2, by @matks
- #15: Add dependabot config file, by @PierreRambaud
- #17: Fix license headers - part 2, by @matks
- #16: Add dependabot config file, by @PierreRambaud
- #13: Fix license headers - part 2, by @matks
- #12: Add dependabot config file, by @PierreRambaud
- #8: Fix license headers - part 2, by @matks
- #7: Add dependabot config file, by @PierreRambaud
- #9: Fix license headers - part 2, by @matks
- #8: Add dependabot config file, by @PierreRambaud
- #8: Fix license headers - part 2, by @matks
- #7: Add dependabot config file, by @PierreRambaud
- #8: Fix license headers - part 2, by @matks
- #7: Add dependabot config file, by @PierreRambaud
- #8: Fix license headers - part 2, by @matks
- #7: Add dependabot config file, by @PierreRambaud
- #14: Fix license headers - part 2, by @matks
- #13: Add dependabot config file, by @PierreRambaud
- #9: Fix license headers - part 2, by @matks
- #8: Add dependabot config file, by @PierreRambaud
- #20: Fix license headers - part 2, by @matks
- #19: Add dependabot config file, by @PierreRambaud
- #42: Fix license headers - part 2, by @matks
- #41: Add dependabot config file, by @PierreRambaud
- #22: Fix license headers - part 2, by @matks
- #27: Fix license headers - part 2, by @matks
- #26: Add dependabot config file, by @PierreRambaud
- #13: Fix license headers - part 2, by @matks
- #40: Fix license headers - part 2, by @matks
- #39: Add dependabot config file, by @PierreRambaud
- #36: Fix license headers - part 2, by @matks
- #35: Add dependabot config file, by @PierreRambaud
- #37: Fix license headers - part 2, by @matks
- #21: Fix license headers - part 2, by @matks
- #64: Fix license headers - part 2, by @matks
- #63: Add dependabot config file, by @PierreRambaud
- #144: Fix license headers - part 2, by @matks
- #143: Add dependabot config file, by @PierreRambaud
- #13: Fix license headers - part 2, by @matks
- #12: Add dependabot config file, by @PierreRambaud
- #13: Fix license headers - part 2, by @matks
- #12: Add dependabot config file, by @PierreRambaud
- #31: Fix license headers - part 2, by @matks
- #30: Add dependabot config file, by @PierreRambaud
- #28: Fix license headers - part 2, by @matks
- #22: Fix license headers - part 2, by @matks
- #21: Add dependabot config file, by @PierreRambaud
- #47: Fix license headers - part 2, by @matks
- #46: Add dependabot config file, by @PierreRambaud
- #63: Add dependabot config file, by @PierreRambaud
- #53: Add dependabot config file, by @PierreRambaud
- #19: Add dependabot config file, by @PierreRambaud
- #51: Add dependabot config file, by @PierreRambaud
- #66: Add dependabot config file, by @PierreRambaud
- #11: Add dependabot config file, by @PierreRambaud
- #12: Add dependabot config file, by @PierreRambaud
- #57: Add dependabot config file, by @PierreRambaud
- #31: Add dependabot config file, by @PierreRambaud
- #24: Add dependabot config file, by @PierreRambaud
- #43: Add dependabot config file, by @PierreRambaud
- #20: Add dependabot config file, by @PierreRambaud
- #37: Add dependabot config file, by @PierreRambaud
- #100: Add dependabot config file, by @PierreRambaud
- #21: Add dependabot config file, by @PierreRambaud
- #53: Add dependabot config file, by @PierreRambaud
- #30: Add dependabot config file, by @PierreRambaud
- #186: Add dependabot config file, by @PierreRambaud
- #66: Add dependabot config file, by @PierreRambaud
- #13: Add dependabot config file, by @PierreRambaud
- #24: Add dependabot config file, by @PierreRambaud
Thank you to the contributors whose pull requests were merged since the last Core Weekly Report: @NeOMakinG, @zalexki, @jolelievre, @Quetzacoalt91, @davidglezz, @boubkerbribri, @PierreRambaud, @eternoendless, @Sinepel, @matks, @nesrineabdmouleh, @sowbiba, @ttoine, @Progi1984, @dependabot[bot], @dependabot-preview[bot], @joserprieto, @PululuK, @JevgenijVisockij, @ksaandev, @olecorre, @Oksydan, @rmilecki, @kpodemski, @dgonzalez360, @Leenwt, @apacios!
Thank you to the contributors whose PRs haven’t been merged yet! And of course, a big thank you to all those who contribute with issues and comments on GitHub!
If you want to contribute to PrestaShop with code, please read these pages first:
…and if you do not know how to fix an issue but wish to report it, please read this: How to use GitHub to report an issue. Thank you!
Happy contributin’ everyone!