This edition of the Core Weekly report highlights changes in PrestaShop’s core codebase from Monday 14th to Sunday 20th of September 2020.
General messages
Dear developers,
PrestaShop project has reached a major open source milestone: the role of maintainer has been opened.
For years only PrestaShop employees could become maintainers for the project. This is not true anymore. Involved contributors can now apply for the position if they want to help the project to go forward.
Some applications have already been submitted and will follow the voting process described in the rules.
In the meanwhile, there are no more ‘todo’ items in the 1.7.7 backlog. Once only the column ‘Done’ contains items, the Release Candidate 1 will be built and published. And if no issues are found in this version… then PrestaShop 1.7.7.0 will be out!
Releases
A quick update about PrestaShop’s GitHub issues and pull requests:
- 81 new issues have been created in the project repositories;
- 52 issues have been closed, including 13 fixed issues on the core;
- 72 pull requests have been opened in the project repositories;
- 98 pull requests have been closed, including 76 merged pull requests.
Code changes in the ‘develop’ branch
Core
- #20990: Fix autoload for composer 2.0 to be compliant with PSR-4, by @PierreRambaud
- #20969: Remove useless comments. Thank you @PululuK
- #20891: Update Mobiledetect library. Thank you @PululuK
- #18985: Allow deprecation notices to be caught nicely even in dev mode, by @Quetzacoalt91
Back office
- #21060: Fix get scalar value from VO in recently merged deleter services. Thank you @zuk3975
- #21053: Introduce CannotBulkDeleteCustomizationFieldException. Thank you @zuk3975
- #20998: Use php FILTER_VALIDATE_DOMAIN filter in MediaServerConfiguration’s validateConfiguration method, by @matthieu-rolland
- #20965: Remove undefined 2nd argument passed to scrollToPreviousPaginationBar(). Thank you @davidglezz
- #20940: Check if SSL is enabled for smarty $base_url. Thank you @okom3pom
- #20926: Addons url with good language when exist. Thank you @okom3pom
- #20828: Introduce ManufacturerIdInterface for ValueObjects, by @jolelievre
- #20805: Add DeleteProductCommand and BulkDeleteProductCommand. Thank you @zuk3975
- #20688: Show profile icon on mobile and hide see my shop text, by @NeOMakinG
- #20549: Add RemoveAllCustomizationFieldsFromProductCommand And Introduce AbstractObjectModelPersister. Thank you @zuk3975
- #20413: Use SymfonyContainer::getInstance() instead of ContainerBuilder::getContainer(‘admin’), by @atomiix
Installer
- #19757: Add a CLI option for fixtures, by @Progi1984
Merge
- #20983: Merge 177x into develop 14/09/2020, by @jolelievre
Code changes in the ‘1.7.7.x’ branch
Core
- #20992: Update live polyfill in BO, FO core theme, and remove it from FO classic theme, by @matthieu-rolland
Back office
- #20960: Fix bulk actions in Carriers page, by @atomiix
- #20936: Fix navbar scroll on mobile display, by @sowbiba
- #20911: Fix glyph.png asset path. Thank you @okom3pom
- #20902: Keep order detail from being updated in BO > Order detail page, when product doesn’t exist anymore, by @matthieu-rolland
Tests
- #21056: Fix tests errors in nightly 18-09-20, by @boubkerbribri
- #21043: Fix test context in ‘Sort and pagination image settings’. Thank you @nesrineabdmouleh
- #21040: Add test ‘Sort Stores’, by @boubkerbribri
- #21029: Delete force install playwright on docker, by @boubkerbribri
- #20997: Add test ‘Sort and pagination image settings’. Thank you @nesrineabdmouleh
- #20988: Fix ‘CRUD Cart Rule’ Test, by @boubkerbribri
- #20961: Add test ‘Filter, quick edit and bulk actions cart rules’, by @boubkerbribri
- #20932: Add test ‘Bulk actions states’, by @boubkerbribri
- #20847: Add test ‘Configure contact details’. Thank you @nesrineabdmouleh
Code changes in modules, themes & tools
Faceted search module
- #212: Bump webpack from 4.44.1 to 4.44.2. Thank you @dependabot[bot]
- #211: Bump mini-css-extract-plugin from 0.11.1 to 0.11.2. Thank you @dependabot[bot]
Changes in developer documentation
- #736: How to become a maintainer: Add a link for creating the issue, by @ttoine
- #735: Fix doc List of hooks. Thank you @PululuK
- #734: missing translation. Thank you @moncef-essid
- #732: Missing translation. Thank you @moncef-essid
- #731: Align columns Webservices Tables, by @Progi1984
- #730: Remove duplicate. Thank you @moncef-essid
- #729: Fixes writing mistake, bad pattern name. Thank you @moncef-essid
- #728: Typo fix in admin controllers. Thank you @moncef-essid
- #727: Writing mistake admin controllers page. Thank you @moncef-essid
- #726: Introducing new webservice documentation resources, by @PierreRambaud
- #723: Correcting trans() calls in module’s controllers. Thank you @moncef-essid
- #722: missing $ symbol. Thank you @moncef-essid
- #716: Explain the Migration strategy and roadmap, by @matks
Buy button lite module
- #42: Bump lodash from 4.17.15 to 4.17.20 in /app. Thank you @dependabot[bot]
- #41: Bump http-proxy from 1.17.0 to 1.18.1 in /app. Thank you @dependabot[bot]
- #40: Bump lodash.mergewith from 4.6.1 to 4.6.2 in /app. Thank you @dependabot[bot]
- #39: Bump node-sass from 4.9.3 to 4.13.1 in /app. Thank you @dependabot[bot]
jQuery Live Polyfill library
- #5: Update version, by @matthieu-rolland
- #4: update minified dist file, by @matthieu-rolland
- #3: Remove usage of migrateWarn function, by @matthieu-rolland
PrestaShop contributors website
Contact Form module
- #51: Bump version, by @PierreRambaud
- #50: Release 4.3.0, by @PierreRambaud
- #49: Changed way to get the order id into $var_list array. Thank you @jordiweblidera
Check payment module
- #39: Updated dev branch from master changes, by @Progi1984
- #38: Fixed CI and update dev from master, by @Progi1984
Custom text module
- #44: Release 4.1.1, by @Progi1984
- #43: Improve project & Bump version to 4.1.1, by @Progi1984
Customer “Sign in” link module
- #25: Release 2.0.3, by @Progi1984
- #24: Improve project & Bump version to 2.0.3, by @Progi1984
Shopping cart module
- #67: Fixed CI & Bump version to 2.0.4 , by @Progi1984
Example modules
Issues Bot
- #9: Bump node-fetch from 2.6.0 to 2.6.1. Thank you @dependabot[bot]
OnBoarding module
- #75: Bump imports-loader from 0.6.5 to 0.8.0. Thank you @dependabot[bot]
- #74: Bump style-loader from 0.13.2 to 0.23.1. Thank you @dependabot[bot]
- #73: Bump exports-loader from 0.6.4 to 0.7.0. Thank you @dependabot[bot]
Google Analytics module
- #73: Avoid force hooking of ps_featuredproducts on displayHome hook, by @matks
- #72: Add Configuration option to disable Back Office tracking, by @matks
- #68: Handle NOW correctly when creating order and register in SQL, by @matks
- #67: Fix logic, avoid double pageview for BO pages, by @matks
- #59: Avoid array to string error on homepage with cart. Thank you @Guisardo
Prestashop UI Kit
- #102: Use local version of fonts in case of offline use, by @NeOMakinG
Product Comments module
- #65: Fix line breaks of comments not existing anymore on FO, by @NeOMakinG
Thank you to the contributors whose pull requests were merged since the last Core Weekly Report: @zuk3975, @boubkerbribri, @dependabot[bot], @nesrineabdmouleh, @ttoine, @matthieu-rolland, @PululuK, @PierreRambaud, @moncef-essid, @Progi1984, @jolelievre, @davidglezz, @atomiix, @matks, @okom3pom, @sowbiba, @jordiweblidera, @NeOMakinG, @Guisardo, @Quetzacoalt91!
Thank you to the contributors whose PRs haven’t been merged yet! And of course, a big thank you to all those who contribute with issues and comments on GitHub!
If you want to contribute to PrestaShop with code, please read these pages first:
…and if you do not know how to fix an issue but wish to report it, please read this: How to use GitHub to report an issue. Thank you!
Happy contributin’ everyone!