This edition of the Core Weekly report highlights changes in PrestaShop’s core codebase from Monday 5th to Sunday 11th of October 2020.
General messages
Dear developers,
The Quality Assurance team found multiple issues in the first build of PrestaShop 1.7.7.0 Release Candidate 1, and the issues list contains one critical bug and one major bug:
- #21300 Missing Gift and Recycled packaging options when Creating a new Order
- #21323 Incorrect discount value and amount in View an Order page when using multiple currencies
Unfortunately, the Release Candidate 1 cannot be released because of these bugs.
The bug reports have been moved into the 1.7.7 Kanban and are currently being fixed. Following the fixes, maintainers team will be able to build a new ZIP archive which will be Release Candidate 1 build 2 and it will be delivered to QA team again for validation.
As usual, informations about the release status will be provided on the release tracking issue for 1.7.7.0 .
Releases
A quick update about PrestaShop’s GitHub issues and pull requests:
- 56 new issues have been created in the project repositories;
- 57 issues have been closed, including 18 fixed issues on the core;
- 112 pull requests have been opened in the project repositories;
- 112 pull requests have been closed, including 93 merged pull requests.
Code changes in the ‘develop’ branch
Core
- #21365: Fixed Currency Numeric Iso Code (Nullable & Default Value), by @Progi1984
- #21314: Tools::getDefaultIndexContent() generates obsolete headers. Thank you @PululuK
- #21279: Carrier: improve documentation of shipping properties. Thank you @rmilecki
- #21057: Reduce conditions complexity. Thank you @davidglezz
- #20653: HelperForm field label not work in switch type . Thank you @PululuK
Back office
- #21372: Update decimal number to version 1.4 And update all use statements, by @jolelievre
- #21335: Fixed “Add new alias” button which was disappearing after adding a new alias. BO Shop param search. Thank you @roncarino
- #21328: Improve SQL requests on specific prices. Thank you @clotaire202
- #21307: Refacto UpdateProductOptionsHandler to use Product repository. Thank you @zuk3975
- #21301: Add commands for Specific Price priorities handling. Thank you @zuk3975
- #21295: Deprecated AddSpecificPriceCommand getter/setter & clarified misnamed property. Thank you @zuk3975
- #21276: Fix typo in AdminController code. Thank you @ksaandev
- #21260: Remove Add/Update/Delete CustomizationField handlers (Redundant & Untested). Thank you @zuk3975
- #21239: Fix deletion message in edit product page, by @marionf
- #21226: Modify partial update in AbstractObjectModelRepository to simplify argument & implement it in UpdateProductBasicInformationHandler. Thank you @zuk3975
- #21218: Fix tab entity tabLangs variable mapping. Thank you @aleksiuno
- #21215: Improvement/emphasize irreversibly of thumbs regeneration. Thank you @aleksiuno
- #21168: Fix FrontController names in modules hook-exceptions. Thank you @dali-rajab
Front office
- #21330: Return a real 404 when product doesn’t exist instead of a 302 redirection. Thank you @Sinepel
- #21217: Make FO product delivery time bold. Thank you @aleksiuno
Tests
Code changes in the ‘1.7.7.x’ branch
Back office
- #21344: Move product search controller that was not in the right place, by @jolelievre
- #21343: Fix status dropdown of order listing page not being well displayed using rtl language, by @NeOMakinG
- #21317: Notifications bell icon read fix (Backport). Thank you @okom3pom
- #21310: Fix delete order state confirmation, by @sowbiba
- #21232: Fix tab modules list, by @sowbiba
- #20882: Recompute specific price tax excluded when mismatch with price tax included, by @matthieu-rolland
Front office
- #21297: Fix variable name in order_customer_comment.html.twig. Thank you @okom3pom
- #21266: Fix wrong combination image shown when clicking to zoom, by @atomiix
- #20927: Avoid possible notice due to breaking change. Thank you @kpodemski
Installer
- #20201: Fix throw InstallControllerHttpSystem::trans during installation process. Thank you @mushroot
Tests
- #21367: Add test ‘CRUD catalog price rule’. Thank you @nesrineabdmouleh
- #21341: Fix test ‘CRUD carrier’ in nightly 07/10/2020. Thank you @nesrineabdmouleh
- #21339: Delete all references to ttc in UI folder, by @boubkerbribri
- #21334: Create state with only iso code that does not exist, by @boubkerbribri
- #21327: Create first test ‘Computing precision set to 3’ for UI tests new campaign ‘Regression’, by @boubkerbribri
- #21324: Add new test ‘Change position for attributes and values’, by @boubkerbribri
- #21308: Fix tests errors in nightly 04/10/2020. Thank you @nesrineabdmouleh
- #21302: Change UI tests workflow name, by @boubkerbribri
- #21255: Add test ‘Sort and pagination shopping carts’. Thank you @nesrineabdmouleh
Code changes in modules, themes & tools
Contact Form module
- #53: Confirmation text after settings change. Thank you @kpodemski
Browsers and operating systems statistics module
Brands list module
Best-selling products statistics module
OnBoarding module
- #80: Bump eslint-plugin-import from 2.22.0 to 2.22.1. Thank you @dependabot[bot]
- #76: Improve project, by @Progi1984
Wire payment module
- #58: Buttons should be updated, by @khouloudbelguith
Share Buttons module
- #44: Buttons should be updated, by @khouloudbelguith
Image slider module
- #55: Buttons should be updated, by @PierreRambaud
Product Comments module
- #73: Buttons should be updated, by @PierreRambaud
Data mining for statistics module
- #18: Buttons should be updated, by @PierreRambaud
Main menu module
- #38: Update buttons, by @khouloudbelguith
Shopping cart module
- #69: Modules - Buttons should be updated, by @khouloudbelguith
Cross-selling module
- #19: Modules - Buttons should be updated. Thank you @PululuK
- #16: Update icon and short description, by @LouiseBonnard
PrestaShop Specifications
- #150: Update the link of the product team in the readme, by @marionf
- #149: Fix more typos in README. Thank you @justeen35
- #148: Spell correctly the project name. Thank you @justeen35
- #147: Add a PULL_REQUEST_TEMPLATE.md to get rid of the current template. Thank you @justeen35
- #146: Fix broken image links. Thank you @justeen35
- #144: Another .DS_Store file that needs to go in the bin. Thank you @justeen35
- #143: Multiple small mistakes fixed. Thank you @justeen35
- #142: Add specs for stock management, by @marionf
- #141: Add specs for gift wrapping message, by @marionf
- #140: Add missing Shipping specs, by @marionf
- #139: Delete .DS_Store file in root folder. Thank you @justeen35
- #138: Fix some statements. Thank you @justeen35
- #137: Add links to the repository tree, by @LouiseBonnard
- #136: Add missing fields in edit product specs and rename labels for prices fields, by @marionf
- #134: Add specifications about thumbnails regeneration, by @LouiseBonnard
Faceted search module
- #216: Bump mini-css-extract-plugin from 0.11.3 to 0.12.0. Thank you @dependabot[bot]
- #215: Bump mini-css-extract-plugin from 0.11.2 to 0.11.3. Thank you @dependabot[bot]
- #214: Bump style-loader from 1.2.1 to 1.3.0. Thank you @dependabot[bot]
Wishlist block module
- #87: Filter on current shop when displaying products in wishlist, by @Quetzacoalt91
Decimal library
- #8: Rename Number to DecimalNumber, by @eternoendless
PrestonBot
Changes in developer documentation
- #768: Fix indentation and missing closing IfModule tag, by @PierreRambaud
- #765: Add a workaround for core table altering, by @Quetzacoalt91
- #763: Add a link for to register. Thank you @okom3pom
- #760: Add informations for MAMP. Thank you @okom3pom
- #755: Explain how to use TOKEN to disable BO token security, by @matks
Best vouchers statistics module
Best suppliers statistics module
Best customers statistics module
- #17: Update short description and logo. Thank you @Julievrz
- #16: Return best customers if visits are not logged. Thank you @jf-viguier
Best categories statistics module
Banner module
Available quantities statistics module
MJML Theme Converter
- #6: Fix typo in variable name, by @eternoendless
Advertising module
Custom text module
- #46: Little improvements to module. Thank you @kpodemski
Gamification module
- #74: Add lazy native attribute to images to avoid loading when hidden, by @NeOMakinG
Thank you to the contributors whose pull requests were merged since the last Core Weekly Report: @kpodemski, @Julievrz, @dependabot[bot], @jolelievre, @nesrineabdmouleh, @khouloudbelguith, @PierreRambaud, @PululuK, @Progi1984, @marionf, @Quetzacoalt91, @NeOMakinG, @eternoendless, @atomiix, @boubkerbribri, @roncarino, @Sinepel, @clotaire202, @jf-viguier, @okom3pom, @justeen35, @sowbiba, @zuk3975, @rmilecki, @ksaandev, @matks, @LouiseBonnard, @aleksiuno, @dali-rajab, @davidglezz, @matthieu-rolland, @mushroot!
Thank you to the contributors whose PRs haven’t been merged yet! And of course, a big thank you to all those who contribute with issues and comments on GitHub!
If you want to contribute to PrestaShop with code, please read these pages first:
…and if you do not know how to fix an issue but wish to report it, please read this: How to use GitHub to report an issue. Thank you!
Happy contributin’ everyone!